Skip to content

Comments

fix error when activating windows environment in public CI#2251

Merged
ndgrigorian merged 1 commit intomasterfrom
maint/fix-windows-build-env-error
Feb 19, 2026
Merged

fix error when activating windows environment in public CI#2251
ndgrigorian merged 1 commit intomasterfrom
maint/fix-windows-build-env-error

Conversation

@ndgrigorian
Copy link
Collaborator

@ndgrigorian ndgrigorian commented Feb 19, 2026

This PR fixes an error raised in Windows public CI, attempting to activate "build" env

Windows builds now work in the base env, same as Linux

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?
  • If this PR is a work in progress, are you opening the PR as a draft?

@github-actions
Copy link

github-actions bot commented Feb 19, 2026 •
edited
Loading

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@github-actions
Copy link

github-actions bot commented Feb 19, 2026

Array API standard conformance tests for dpctl=0.22.0dev1=py310h93fe807_4 ran successfully.
Passed: 1247
Failed: 41
Skipped: 80

@coveralls
Copy link
Collaborator

coveralls commented Feb 19, 2026 •
edited
Loading

Coverage Status

coverage: 86.248%. remained the same
when pulling bb36861 on maint/fix-windows-build-env-error
into ee7565e on master.

@ndgrigorian ndgrigorian force-pushed the maint/fix-windows-build-env-error branch from c536430 to bb36861 Compare February 19, 2026 02:35
@github-actions
Copy link

github-actions bot commented Feb 19, 2026

Array API standard conformance tests for dpctl=0.22.0dev1=py310h93fe807_4 ran successfully.
Passed: 1247
Failed: 41
Skipped: 80

@ndgrigorian ndgrigorian marked this pull request as ready for review February 19, 2026 08:54
@ndgrigorian
Copy link
Collaborator Author

ndgrigorian commented Feb 19, 2026

Error EnvironmentNameNotFound: Could not find conda environment: test_dpctl You can list all discoverable environments with conda info --envs. occurs still in the test phase, but the environment still activates and runs the tests, so I will consider this an unrelated bug (the error is raised when conda create is called)

vlad-perevezentsev
vlad-perevezentsev reviewed Feb 19, 2026
View reviewed changes
@github-actions
Copy link

github-actions bot commented Feb 19, 2026

Array API standard conformance tests for dpctl=0.22.0dev1=py310h93fe807_5 ran successfully.
Passed: 1248
Failed: 40
Skipped: 80

@ndgrigorian ndgrigorian force-pushed the maint/fix-windows-build-env-error branch from 5e3df59 to bb36861 Compare February 19, 2026 20:11
@github-actions
Copy link

github-actions bot commented Feb 19, 2026

Array API standard conformance tests for dpctl=0.22.0dev1=py310h93fe807_4 ran successfully.
Passed: 1248
Failed: 40
Skipped: 80

vlad-perevezentsev
vlad-perevezentsev approved these changes Feb 19, 2026
View reviewed changes
Copy link
Collaborator

@vlad-perevezentsev vlad-perevezentsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thank you @ndgrigorian

@ndgrigorian ndgrigorian merged commit 0a329ef into master Feb 19, 2026
108 of 125 checks passed
@ndgrigorian ndgrigorian deleted the maint/fix-windows-build-env-error branch February 19, 2026 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vlad-perevezentsev vlad-perevezentsev vlad-perevezentsev approved these changes

@antonwolfy antonwolfy Awaiting requested review from antonwolfy antonwolfy is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ndgrigorian @coveralls @vlad-perevezentsev